Ability to search for user tags on comment and post inputs #2185
Conversation
|
@Reinachan here it is! Honestly not a big deal if this never gets merged, it was a fun experiment and trying to get used to ember.js; ill most likely never ever need this ability but ah well :P |
There was a problem hiding this comment.
Thank you for the PR, I generally love this, but there are some usability things I think needs to be addressed before this can be merged.
I don't like that it disappears after a couple of seconds. I'd rather it disappears if you click outside the box.
It's using dark colours whether you're in light-theme or dark-theme. Is that intentional? I think it would be better to make it look more like the existing dropdown menues colour-wise.
Currently it's kinda in a weird space between being a "tooltip" and a dedicated block. I'd suggest either making it appear underneath the location you're writing the mention or have it insert itself as a block above the post button. I think the first option is preferred as it's possible to write a long post and then go back and add a mention at the top.
It should show up immediately when you type an @. If you haven't loaded any users yet, display a loading indicator. I didn't think it was working at first because it wasn't showing up immediately.
You should be able to select other users with the keyboard, not just the top result. I suggest making arrowkeys navigate a selection and tab and enter inserting it. I also think the first result should be highlighted initially.
The comment input is gone! Which speaking of, this should ideally integrate there too.
I'd suggest you look at GitHub's popup for @ mentions.
TL:DR
The changes I request are
- make it disappear when the typing cursor is no longer at relevant text
- make it no longer disappear on a timer
- make it appear under the @ rather than under the post
- make it show immediately when typing a character after @. Show loader if there's no data yet.
- make it keyboard-friendly. Arrow keys should move a selection and tab and enter should insert it.
- fix the bug that hides the comments input
Description
When users are typing in the create post input or any comment box, they can type '@' and what immediately follows will be a user tag query. If they are satisfied with the top result, they may hit 'TAB' to autocomplete the top user tag. Otherwise, they may select a value from the dropdown of results that is tethered to the input box with a 5 second lifespan (before it is cleared)
Gifs :)
/cc @hummingbird-me/staff