Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling improvements #4

Merged
merged 11 commits into from Jun 22, 2020
Merged

Tooling improvements #4

merged 11 commits into from Jun 22, 2020

Conversation

tfrommen
Copy link
Contributor

Hey! 👋

This PR includes a number of unrelated improvements to various tooling:

  • PHP_CodeSniffer: Reference HM standard by name, not path.
  • PHPUnit: Remove default attribute (7.5 config - 9.2 config), sort attributes, and improve coverage setup.
  • Simplify and improve browsers list (see best-practices).
  • Composer: Simplify running Composer scripts.
  • Composer: Sort packages.
  • Remove empty dependencies section.
  • Travis: Ensure installing PHP dependencies is quick and doesn't fail the build.
  • Use Composer "test" script as canonical way to run PHP tests.
  • Test bootstrap: Extract and align base directory.
  • PHPUnit: Replace deprecated "assertInternalType" with "assertIsInt" (see Deprecate assertInternalType() and assertNotInternalType() sebastianbergmann/phpunit#3369).

In case you don't like a partciular thing, feel free to chery-pick. 🍒

@tfrommen tfrommen requested a review from kadamwhite June 16, 2020 06:49
Copy link
Collaborator

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @tfrommen !

@kadamwhite kadamwhite merged commit 93331cd into master Jun 22, 2020
@kadamwhite kadamwhite deleted the tooling branch June 22, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants