Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated install-venv #81

Merged
merged 4 commits into from Feb 25, 2022

Conversation

radarhere
Copy link

Copy link
Owner

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some suggestions!

Makefile Outdated
@@ -9,9 +9,11 @@ clean:

.PHONY: coverage
coverage:
pytest -qq
python3 -c "import pytest" || python3 -m pip install pytest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's redirect all these to /dev/null to avoid the error message:

python3 -c "import pytest" || python3 -m pip install pytest
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'pytest'
Collecting pytest
...
Suggested change
python3 -c "import pytest" || python3 -m pip install pytest
python3 -c "import pytest" > /dev/null 2>&1 || python3 -m pip install pytest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

docs/Makefile Outdated
Comment on lines 44 to 45
html:
python3 -c "import sphinx" || python3 -m pip install sphinx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And when we have multiple we can remove duplication something like:

Suggested change
html:
python3 -c "import sphinx" || python3 -m pip install sphinx
install-sphinx:
python3 -c "import sphinx" > /dev/null 2>&1 || python3 -m pip install sphinx
html: install-sphinx

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done

@hugovk hugovk merged commit 7ee9a0e into hugovk:extras_require Feb 25, 2022
@hugovk
Copy link
Owner

hugovk commented Feb 25, 2022

Thanks!

@radarhere radarhere deleted the extras_require branch February 25, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants