New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated install-venv #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some suggestions!
Makefile
Outdated
@@ -9,9 +9,11 @@ clean: | |||
|
|||
.PHONY: coverage | |||
coverage: | |||
pytest -qq | |||
python3 -c "import pytest" || python3 -m pip install pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's redirect all these to /dev/null
to avoid the error message:
python3 -c "import pytest" || python3 -m pip install pytest
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'pytest'
Collecting pytest
...
python3 -c "import pytest" || python3 -m pip install pytest | |
python3 -c "import pytest" > /dev/null 2>&1 || python3 -m pip install pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done
docs/Makefile
Outdated
html: | ||
python3 -c "import sphinx" || python3 -m pip install sphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And when we have multiple we can remove duplication something like:
html: | |
python3 -c "import sphinx" || python3 -m pip install sphinx | |
install-sphinx: | |
python3 -c "import sphinx" > /dev/null 2>&1 || python3 -m pip install sphinx | |
html: install-sphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done
f3f3bea
to
c55d5d2
Compare
d55cc8f
to
2e71925
Compare
Thanks! |
Helps python-pillow#6072