Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build ci image #30933

Merged
merged 62 commits into from
May 22, 2024
Merged

Update build ci image #30933

merged 62 commits into from
May 22, 2024

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented May 21, 2024

What does this PR do?

Update script!
New workflow:

  1. always checkout push-ci-image
  2. do your thing
  3. push a commit with [build-ci-image]
  4. check the build
  5. push a commit with [push-ci-image]
  6. close the pr and delete the branch.
  7. DONE

@ArthurZucker ArthurZucker marked this pull request as ready for review May 21, 2024 10:21
@ArthurZucker ArthurZucker requested review from LysandreJik and ydshieh and removed request for LysandreJik May 21, 2024 10:21
@ArthurZucker
Copy link
Collaborator Author

I need this to merge #30932

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure Yih-Dar has seen the PR as well

@ydshieh ydshieh self-assigned this May 21, 2024
@ydshieh
Copy link
Collaborator

ydshieh commented May 21, 2024

Looks good to me. Just to comment that, by delete the branch you mean the remote branch I believe.

@ydshieh
Copy link
Collaborator

ydshieh commented May 21, 2024

BTW, this verifies the images could be built successfully. But this doesn't verify that if those new images would make the CircleCI green or red. I am somehow concerned this part.

.circleci/config.yml Outdated Show resolved Hide resolved
@@ -176,7 +176,7 @@
"tensorflow-probability<2.16",
"tf2onnx",
"timeout-decorator",
"timm",
"timm<=0.9.16",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyeroberts I ended up pinning this, feel free to unpin once you feel like it

@ArthurZucker ArthurZucker merged commit 8e8786e into main May 22, 2024
20 of 23 checks passed
@ArthurZucker ArthurZucker deleted the push-ci-image branch May 22, 2024 08:53
@ArthurZucker ArthurZucker restored the push-ci-image branch May 22, 2024 08:54
Vaibhavs10 pushed a commit to Vaibhavs10/transformers that referenced this pull request May 22, 2024
* [build-ci-image]

* correct branch

* push ci image

* [build-ci-image]

* update scheduled as well

* [push-ci-image]

* [build-ci-image]

* [push-ci-image]

* update deps

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* oups [build-ci-image]

* [push-ci-image]

* fix

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* updated

* [build-ci-image] update tag

* [build-ci-image]

* [build-ci-image]

* fix tag

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* github name

* commit_title?

* fetch

* update

* it not found

* dev

* dev

* [push-ci-image]

* dev

* dev

* update

* dev

* dev print dev commit message dev

* dev ? dev

* dev

* dev

* dev

* dev

* [build-ci-image]

* [build-ci-image]

* [push-ci-image]

* revert unwanted

* revert convert as well

* no you are not important

* [build-ci-image]

* Update .circleci/config.yml

* pin tf probability dev
itazap pushed a commit that referenced this pull request May 24, 2024
* [build-ci-image]

* correct branch

* push ci image

* [build-ci-image]

* update scheduled as well

* [push-ci-image]

* [build-ci-image]

* [push-ci-image]

* update deps

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* oups [build-ci-image]

* [push-ci-image]

* fix

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* updated

* [build-ci-image] update tag

* [build-ci-image]

* [build-ci-image]

* fix tag

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* [build-ci-image]

* github name

* commit_title?

* fetch

* update

* it not found

* dev

* dev

* [push-ci-image]

* dev

* dev

* update

* dev

* dev print dev commit message dev

* dev ? dev

* dev

* dev

* dev

* dev

* [build-ci-image]

* [build-ci-image]

* [push-ci-image]

* revert unwanted

* revert convert as well

* no you are not important

* [build-ci-image]

* Update .circleci/config.yml

* pin tf probability dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants