-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gptj] support older pytorch version #22325
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Thank you for the quick review, Sylvain. |
You haven't done anything wrong, Nick. It's just very difficult to instantly test all the different variations. We have more indepth multi-version CI running on a daily basis, so usually any missed problems get detected on the next day. And thank you for your contribution! |
* [gptj] support older pytorch version * contributor * contributor * make copies --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Nick Hill <nickhill@us.ibm.com>
* [gptj] support older pytorch version * contributor * contributor * make copies --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Nick Hill <nickhill@us.ibm.com>
Unbreak 2 issues introduced by #22069 . I validated that this version works even with pt-1.9, which is the new lowest version supported by transformers since #22291
Fixes:
credits for the fix: @mrwyattii
and:
credits for the fix: @njhill