Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline] fix Whisper test #20646

Closed

Conversation

sanchit-gandhi
Copy link
Contributor

@sanchit-gandhi sanchit-gandhi commented Dec 7, 2022

What does this PR do?

Fixes Whisper pipeline test.

Previously, we suppressed the hyphen and apostrophe tokens from Whisper generation, meaning they were alway predicted with zero probability. This meant that these tokens could never be predicted. With the Hub PR https://huggingface.co/openai/whisper-large/discussions/12, these tokens were removed from the set of suppressed tokens, meaning they can now (correctly) be predicted with non-zero probability.

We get the correct contraction now in the Italian prediction: "allo universo" -> "all'universo"

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @ydshieh @sgugger

@sanchit-gandhi
Copy link
Contributor Author

Test already fixed in #20588

@sanchit-gandhi sanchit-gandhi deleted the pipeline-test branch June 25, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant