Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for Italian translation and add quicktour.mdx translation #17472

Merged
merged 8 commits into from May 31, 2022

Conversation

mfumanelli
Copy link
Contributor

@mfumanelli mfumanelli commented May 30, 2022

I created the folder for files translated into Italian and made the translation of quicktour.mdx and index.mdx files.

The folder (called 'it') is located in transformers/docs/source/.
The translated documents are located in the transformers/docs/source/it folder.

Fixes #17459

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

@omarespejel @sgugger

Martina Fumanelli and others added 2 commits May 30, 2022 08:43
- Add 'it' folder for files translated into Italian
- Add _config.py and _toctree.yml files
- Add translation of quicktour.mdx
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@omarespejel omarespejel self-requested a review May 30, 2022 14:19
@omarespejel
Copy link
Contributor

This looks great! Thanks @mfumanelli for the PR and opening the venue for an Italian 🇮🇹 translation!

Since this is the first IT translation could please add it to the languages section in the .github/workflows (here and here)?

@omarespejel
Copy link
Contributor

Thank you @mfumanelli 🇮🇹! LGTM, @sgugger :)

- Add index to _toctree.yml
- Add translation of index.mdx
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this new language!

Comment on lines 3 to 5
# Transformers installation
! pip install transformers datasets
# To install from source instead of the last release, comment the command above and uncomment the following one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two comments could be translated in Italian as well :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I hadn't noticed them, thank you 😊 🌈

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem!

@sgugger sgugger merged commit dfc3846 into huggingface:main May 31, 2022
@mfumanelli mfumanelli deleted the translation/italian branch June 1, 2022 09:25
Narsil pushed a commit to Narsil/transformers that referenced this pull request Jun 7, 2022
…ingface#17472)

* Setup for Italian translation and add first document

- Add 'it' folder for files translated into Italian
- Add _config.py and _toctree.yml files
- Add translation of quicktour.mdx

* Fix style issue of italian documentation files

* Add 'it' to the languages section in the .github/workflows

* Remove - installation from _toctree for Italian

* Translation for index file

- Add index to _toctree.yml
- Add translation of index.mdx

* Fix typo in docs/source/it/index.mdx

* Translate code comments in docs/source/it/_config.py

Co-authored-by: Martina Fumanelli <martinafumanelli@Martinas-MBP.homenet.telecomitalia.it>
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…ingface#17472)

* Setup for Italian translation and add first document

- Add 'it' folder for files translated into Italian
- Add _config.py and _toctree.yml files
- Add translation of quicktour.mdx

* Fix style issue of italian documentation files

* Add 'it' to the languages section in the .github/workflows

* Remove - installation from _toctree for Italian

* Translation for index file

- Add index to _toctree.yml
- Add translation of index.mdx

* Fix typo in docs/source/it/index.mdx

* Translate code comments in docs/source/it/_config.py

Co-authored-by: Martina Fumanelli <martinafumanelli@Martinas-MBP.homenet.telecomitalia.it>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
…ingface#17472)

* Setup for Italian translation and add first document

- Add 'it' folder for files translated into Italian
- Add _config.py and _toctree.yml files
- Add translation of quicktour.mdx

* Fix style issue of italian documentation files

* Add 'it' to the languages section in the .github/workflows

* Remove - installation from _toctree for Italian

* Translation for index file

- Add index to _toctree.yml
- Add translation of index.mdx

* Fix typo in docs/source/it/index.mdx

* Translate code comments in docs/source/it/_config.py

Co-authored-by: Martina Fumanelli <martinafumanelli@Martinas-MBP.homenet.telecomitalia.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Italian
4 participants