Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes some key names for in LayoutLMv2 / LayoutXLM tokenizers #14493

Merged

Conversation

valentinkoe
Copy link
Contributor

What does this PR do?

in case of left padding_side there was a (probably copy/paste) error assigning the bbox data to the labels.
I consider this to be a typo fix.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

I guess @sgugger as you reviewed #12604
cc @NielsRogge

in case of left padding_side there was a copy/paste error
assigning the bbox data to the labels
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 0b7d053 into huggingface:master Nov 22, 2021
@valentinkoe valentinkoe deleted the fix_key_names_in_layoutlm_tokenizers branch November 22, 2021 23:38
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
…gface#14493)

in case of left padding_side there was a copy/paste error
assigning the bbox data to the labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants