Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trainer logging_nan_inf_filter in torch_xla mode #13896

Merged
merged 3 commits into from Oct 6, 2021
Merged

Fix trainer logging_nan_inf_filter in torch_xla mode #13896

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ad1850
Fix logging_nan_inf_filter in torch_xla mode
ymwangg Oct 6, 2021
c00d4bf
Update src/transformers/trainer.py
ymwangg Oct 6, 2021
6e9bc00
Fix format
ymwangg Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/transformers/trainer.py
View file
Open in desktop
Expand Up @@ -1311,9 +1311,12 @@ def train(
else:
tr_loss_step = self.training_step(model, inputs)

if args.logging_nan_inf_filter and (torch.isnan(tr_loss_step) or torch.isinf(tr_loss_step)):
# if loss is nan or inf simply add the average of previous logged losses
tr_loss += tr_loss / (1 + self.state.global_step - self._globalstep_last_logged)
if args.logging_nan_inf_filter:
if is_torch_tpu_available():
xm.mark_step()
ymwangg marked this conversation as resolved.
Show resolved Hide resolved
if (torch.isnan(tr_loss_step) or torch.isinf(tr_loss_step)):
# if loss is nan or inf simply add the average of previous logged losses
tr_loss += tr_loss / (1 + self.state.global_step - self._globalstep_last_logged)
else:
tr_loss += tr_loss_step

Expand Down