Fix trainer logging_nan_inf_filter in torch_xla mode #13896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Oct 6, 2021
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
sgugger
approved these changes
Oct 6, 2021
lapisfluvialis
pushed a commit
to lapisfluvialis/transformers
that referenced
this pull request
Oct 27, 2021
* Fix logging_nan_inf_filter in torch_xla mode * Update src/transformers/trainer.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Fix format Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* Fix logging_nan_inf_filter in torch_xla mode * Update src/transformers/trainer.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Fix format Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trainer logging_nan_inf_filter in torch_xla mode
(torch.isnan(tr_loss_step) or torch.isinf(tr_loss_step))will trigger compilation when running torch_xla. This PR fixes this bug.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone who's familiar with torch_xla.