Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contribution guide for merging PRs #856

Merged
merged 2 commits into from Apr 28, 2022
Merged

Update contribution guide for merging PRs #856

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd85ffa
Update CONTRIBUTING.md
stevhliu Apr 27, 2022
5f518c8
apply adrin review
stevhliu Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -215,15 +215,16 @@ Follow these steps to start contributing:
$ git push -u origin a-descriptive-name-for-my-changes
```

7. Once you are satisfied (**and the checklist below is happy too**), go to the
6. Once you are satisfied (**and the checklist below is happy too**), go to the
webpage of your fork on GitHub. Click on 'Pull request' to send your changes
to the project maintainers for review.

8. It's ok if maintainers ask you for changes. It happens to core contributors
7. It's ok if maintainers ask you for changes. It happens to core contributors
too! So everyone can see the changes in the Pull request, work in your local
branch and push the changes to your fork. They will automatically appear in
the pull request.


8. Once your changes have been approved, one of the project maintainers will merge your pull request for you.
stevhliu marked this conversation as resolved.
Show resolved Hide resolved

### Checklist

Expand Down