Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto track binary files #828

Merged
merged 9 commits into from Apr 21, 2022
Merged

Auto track binary files #828

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a4e9b19
Auto track binary files
LysandreJik Apr 8, 2022
35b480c
Add null character check
LysandreJik Apr 8, 2022
57f8613
Tests
LysandreJik Apr 8, 2022
b8bbe4f
Apply suggestions from code review
LysandreJik Apr 12, 2022
17a1331
Only read 512 bytes
LysandreJik Apr 12, 2022
5f48d6c
Address Eliott's comments
LysandreJik Apr 12, 2022
6d27a15
Split test
LysandreJik Apr 12, 2022
9fe6bb6
Address review comments
LysandreJik Apr 18, 2022
cbfdce5
10MB maximum
LysandreJik Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/huggingface_hub/repository.py
View file
Open in desktop
Expand Up @@ -239,7 +239,7 @@ def is_binary_file(filename: Union[str, Path]) -> bool:
"""
try:
with open(filename) as f:
content = f.read()
content = f.read(512)
coyotte508 marked this conversation as resolved.
Show resolved Hide resolved

# Check for the presence of the null character in the string
return "\x00" in content
Expand Down