Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fastai upstream and downstream capacities for fastai>=2.4 and fastcore>=1.3.27 versions #678

Merged
merged 87 commits into from Apr 26, 2022
Merged

Add fastai upstream and downstream capacities for fastai>=2.4 and fastcore>=1.3.27 versions #678

merged 87 commits into from Apr 26, 2022

Commits on Oct 17, 2021

  1. added a fastai mixin for upstream and downstream tasks with fastai li… 

    …brary
    @omarespejel
    omarespejel committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    f237986 View commit details
    Browse the repository at this point in the history

  2. Added check for right fastai version

    @omarespejel
    omarespejel committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    16a10a2 View commit details
    Browse the repository at this point in the history

  3. Added aditional documentation

    @omarespejel
    omarespejel committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    a0398d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Add support for fastai>=2.4 versions and fastcore>=1.3.27

    @omarespejel
    omarespejel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    0e65896 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-fastai-mixin

    @omarespejel
    omarespejel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    aea8b8e View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Update docstrings, save_fastai_learner, push_to_hub_fastai, and chang… 

    …e name from fastai_mixin
    @omarespejel
    omarespejel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    940c68d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-fastai-mixin' of https://github.com/omarespejel/hug… 

    …gingface_hub into add-fastai-mixin
    @omarespejel
    omarespejel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    4b246f4 View commit details
    Browse the repository at this point in the history

  3. trim triling whitespaces

    @omarespejel
    omarespejel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    807e7bb View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2022

  1. Import fastai_utils.py in huggingface_hub/__init__py

    @omarespejel
    omarespejel committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    44493cf View commit details
    Browse the repository at this point in the history

  2. Add check_fastai_fastcore_versions function in fastai_utils.py

    @omarespejel
    omarespejel committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    a7253ed View commit details
    Browse the repository at this point in the history

  3. Eliminate imports of libraries not used in fastai_utils.py

    @omarespejel
    omarespejel committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    5904986 View commit details
    Browse the repository at this point in the history

  4. Add isort and black format to fastai_utils.py

    @omarespejel
    omarespejel committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    18b4498 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Change pickle_protocol argument from kwargs to explicit

    @omarespejel
    omarespejel committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    37b6b51 View commit details
    Browse the repository at this point in the history

  2. Change kwargs arguments in the function from_pretrained_fastai to exp… 

    …licit
    @omarespejel
    omarespejel committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    1c9cff5 View commit details
    Browse the repository at this point in the history

  3. Simplify push_to_hub_fastai function, particularly the repo_id argument

    @omarespejel
    omarespejel committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    2a40a8d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Eliminate search for a pickle document in from_pretrained_fastai func… 

    …tion
    @omarespejel
    omarespejel committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    1a4012c View commit details
    Browse the repository at this point in the history

  2. Simplify push_to_hub_fastai and correct bug in from_pretrained_fastai

    @omarespejel
    omarespejel committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    a9ba5d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Add pickle.DEFAULT_PROTOCOL for get adequate protocol when exporting … 

    …the Learners
    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    68f2006 View commit details
    Browse the repository at this point in the history

  2. Allow to load only models in the Hub when using from_pretrained_fastai

    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    97742cb View commit details
    Browse the repository at this point in the history

  3. Eliminate cache_dir from from_pretrained_fastai for simplification

    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7ba1fdd View commit details
    Browse the repository at this point in the history

  4. Correct nit picks in push_to_hub_fastai

    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    bf7a033 View commit details
    Browse the repository at this point in the history

  5. Update with nits

    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d3da12a View commit details
    Browse the repository at this point in the history

  6. Apply isort

    @omarespejel
    omarespejel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3a66991 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Replace config.json for pyproject.toml to check for fastai and fastco… 

    …re versions
    @omarespejel
    omarespejel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    679187c View commit details
    Browse the repository at this point in the history

  2. Isort imports

    @omarespejel
    omarespejel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    24d3ddb View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Make pyproject.toml automatically filled with fastai, fastcore, and p… 

    …ython versions used.
    @omarespejel
    omarespejel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b0eeb35 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. add check_fastai_fastcore_pyproject_versions function to know the fas… 

    …tai and fastcore versions of the pretrained model to load from the Hub
    @omarespejel
    omarespejel committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    2fb9400 View commit details
    Browse the repository at this point in the history

  2. Change library tomlkit for toml

    @omarespejel
    omarespejel committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    c443bb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Add extras[fastai] with the toml library

    @omarespejel
    omarespejel committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    42b01c3 View commit details
    Browse the repository at this point in the history

  2. Change the way the token is asked in def push_to_hub_fastai(

    @omarespejel
    omarespejel committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    fb886e9 View commit details
    Browse the repository at this point in the history

  3. Eliminate logger from imports

    @omarespejel
    omarespejel committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    effac9f View commit details
    Browse the repository at this point in the history

  4. Fix nits

    @omarespejel
    omarespejel committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    db1cbe9 View commit details
    Browse the repository at this point in the history

  5. Remove typing.Union from imports

    @omarespejel
    omarespejel committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    c9ccff0 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. add fastai integration tests

    @omarespejel
    omarespejel committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    19fad26 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Import fastai in setup.py

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    f72ac27 View commit details
    Browse the repository at this point in the history

  2. Import toml inside check_fastai_fastcore_pyproject_versions function

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    fd63e5a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/huggingface/huggingface_hub … 

    …into add-fastai-mixin
    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    1435d2c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'huggingface:main' into add-fastai-mixin

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    2ee4c56 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'add-fastai-mixin' of https://github.com/omarespejel/hug… 

    …gingface_hub into add-fastai-mixin
    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    bd1c675 View commit details
    Browse the repository at this point in the history

  6. Nits in fastai_utils.py

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    2c38e7b View commit details
    Browse the repository at this point in the history

  7. Add build_fastai to python-tests.yml

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    4013c79 View commit details
    Browse the repository at this point in the history

  8. Add fastcore import to setup.py

    @omarespejel
    omarespejel committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    5e840b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Add require_fastai_fastcore() to skip tests

    @omarespejel
    omarespejel committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    33061cb View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Nits and documentation of raised errors improved

    @omarespejel
    omarespejel committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    6680065 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Merge main branch changes

    Omar Espejel authored and Omar Espejel committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    8ce5894 View commit details
    Browse the repository at this point in the history

  2. add strategy for fastai in python-tests.yml

    Omar Espejel authored and Omar Espejel committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    988d6cd View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Eliminate organization from push_to_hub_fastai

    Omar Espejel authored and Omar Espejel committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    d3585a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Add python 3.7-3.10 to python-tests.yml

    @omarespejel
    omarespejel committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    5699b43 View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts

    @omarespejel
    omarespejel committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    8041b60 View commit details
    Browse the repository at this point in the history

  3. Change python version in tests to 3.9

    @omarespejel
    omarespejel committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    8587464 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Fix tests

    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    421aab3 View commit details
    Browse the repository at this point in the history

  2. Fix conflict in config.py due to order of tf packages

    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    b2e7fa7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into add-fastai-mixin

    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    264537b View commit details
    Browse the repository at this point in the history

  4. Fix delete_repo function in test_fastai_integration

    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    a8e32a3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'add-fastai-mixin' of https://github.com/omarespejel/hug… 

    …gingface_hub into add-fastai-mixin

Update local branch
    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    b061df8 View commit details
    Browse the repository at this point in the history

  6. Isort test_fastai_integration

    @omarespejel
    omarespejel committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    f297f7c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Replace the repo_id name for model_id 

    * Keep the names consistent
    @omarespejel
    omarespejel committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    de7368b View commit details
    Browse the repository at this point in the history

  2. Make fastai and fastcore versions flexible in setup.py 

    * Would be "fastai>=2.4" and "fastcore>=1.3.27"
    @omarespejel
    omarespejel committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    3cfe4d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Confirm fastai supports python 3.10 in python-tests-yml 

    * Version 2.5.6 of fastai supports python 3.10
    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    050904a View commit details
    Browse the repository at this point in the history

  2. Fix docs in fastai_utils.py 

    * Fix functions' arguments documentation for a proper rendering
    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    f3b2000 View commit details
    Browse the repository at this point in the history

  3. Change the name of DummyModel for dummy_model

    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2d12300 View commit details
    Browse the repository at this point in the history

  4. Handle pickling errors when exporting a fastai.Learner 

    * Guide user in how to deal with a PicklingError
    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    edeee68 View commit details
    Browse the repository at this point in the history

  5. Change name of internal functions in fastai_utils.py 

    * Start functions that are not push_to_hub_fastai and from_pretrained_fastai with a "_" to indicate that they are internal functions. They would not be necessary for the user.
    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    028c80a View commit details
    Browse the repository at this point in the history

  6. black style to fastai_utils.py

    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    1bc2c41 View commit details
    Browse the repository at this point in the history

  7. Eliminate unnecessary comments from fastai_utils.py

    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    26c8d15 View commit details
    Browse the repository at this point in the history

  8. Add capacity to load a local fastai.Learner to from_pretrained_keras 

    * In fastai_utils.py.
* This would be in addition to being able to load a pretrained model from the Hub
    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    a7de8c4 View commit details
    Browse the repository at this point in the history

  9. black format fastai_utils.py

    @omarespejel
    omarespejel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    022c571 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Come back to Python 3.9 instead of 3.10 

    * fastai was made compatible with Python 3.10 just in the most recent version 3.5.6 released on April 1st. I would prefer to wait for the next release of fastai.
    @omarespejel
    omarespejel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    5dafb25 View commit details
    Browse the repository at this point in the history

  2. Change name name of save_fastai_learner to _save_pretrained_fastai in… 

    … test_fastai_integration.py
    @omarespejel
    omarespejel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    9a06a67 View commit details
    Browse the repository at this point in the history

  3. Change the name to _save_pretrained_fastai in __init__.py 

    * Additionally, isort test_fastai_integration.py
* Change the name from save_fastai_learner to _save_pretrained_fastai
* isort __init__.py
    @omarespejel
    omarespejel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    004d318 View commit details
    Browse the repository at this point in the history

  4. Fix nits in test_fastai_integration.py

    @omarespejel
    omarespejel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    947d58b View commit details
    Browse the repository at this point in the history

  5. Add fastai integration to docs 

    * functions from_pretrained_fastai and push_to_hub_fastai were added to mixins.mdx
    @omarespejel
    omarespejel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d6ee8bf View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Fix nits

    @omarespejel
    omarespejel committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    18d0d27 View commit details
    Browse the repository at this point in the history

  2. Fix wording

    @omarespejel
    omarespejel committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7e63f46 View commit details
    Browse the repository at this point in the history

  3. Allow _save_pretrained_fastai to directly export the model in save_di… 

    …rectory

* By default learner.export saves learner to learner.path
* Before we where saving the model in learner.path and them moving it to save_directory
* Fix by changing learner.path to being equal to save_directory
    @omarespejel
    omarespejel committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2512ead View commit details
    Browse the repository at this point in the history

  4. black fastai_utils.py

    @omarespejel
    omarespejel committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8633c0e View commit details
    Browse the repository at this point in the history

  5. Make the requirement of having a pyproject.toml optional 

    * Additionally, makes optional that the pyproject.toml contains the fastai and fastcore versions
* Will continue to throw an  error if the toml library is not available
* Will continue to thrown an error if the pyproject.toml specifies fastai or fastcore versions that are not supported by from_pretrained_fastai
* This will allow to load fastai models from the Hub that were not necessarily uploaded using push_to_hub_fastai.
    @omarespejel
    omarespejel committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    363cb81 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Add warnings if the pyproject.toml does not contain a "build-system" … 

    …and "requires" section
    @omarespejel
    omarespejel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    ac0ef8a View commit details
    Browse the repository at this point in the history

  2. Change try-excepts for ifs in the warnings checking the fastai and fa… 

    …stcore versions
    @omarespejel
    omarespejel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    2b28f4b View commit details
    Browse the repository at this point in the history

  3. Fix nits in documentation

    @omarespejel
    omarespejel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    88f4cd0 View commit details
    Browse the repository at this point in the history

  4. Move errors in _check_fastai_fastcore_pyproject_versions to condition… 

    …s after warnings
    @omarespejel
    omarespejel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    d0268a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Misc improvements

    @osanseviero
    osanseviero committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5ffd543 View commit details
    Browse the repository at this point in the history

  2. Move the versions checks for fastai and fastcore to "else"'s 

    * This allows to eliminate the returns when checking for the versions of fastai and fastcore in the pyproject.toml
    @omarespejel
    omarespejel committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f36093e View commit details
    Browse the repository at this point in the history

  3. Move the versions checks for fastai and fastcore to "else"'s 

    * This allows to eliminate the returns when checking for the versions of fastai and fastcore in the pyproject.toml
    @omarespejel
    omarespejel committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    cd4648a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'add-fastai-mixin' of https://github.com/omarespejel/hug… 

    …gingface_hub into add-fastai-mixin
    @omarespejel
    omarespejel committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1795ce8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/huggingface/huggingface_hub … 

    …into add-fastai-mixin
    @omarespejel
    omarespejel committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f9dd4b0 View commit details
    Browse the repository at this point in the history

  6. Black reformat

    @omarespejel
    omarespejel committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    465e0fa View commit details
    Browse the repository at this point in the history