Add fastai upstream and downstream capacities for fastai>=2.4 and fastcore>=1.3.27 versions #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarespejel
changed the title
muellerzr
previously requested changes
Feb 10, 2022
osanseviero
reviewed
Feb 10, 2022
…e name from fastai_mixin
…gingface_hub into add-fastai-mixin
|
Hi, @osanseviero @muellerzr thank you for your kind reviews guys! All feedback was applied and tested. Main changes:
Will be here :D |
|
The failing tests are unrelated. They are flaky and likely not related to this PR, so don't worry about it |
osanseviero
reviewed
Feb 15, 2022
* fastai was made compatible with Python 3.10 just in the most recent version 3.5.6 released on April 1st. I would prefer to wait for the next release of fastai.
… test_fastai_integration.py
* Additionally, isort test_fastai_integration.py * Change the name from save_fastai_learner to _save_pretrained_fastai * isort __init__.py
* functions from_pretrained_fastai and push_to_hub_fastai were added to mixins.mdx
osanseviero
reviewed
Apr 20, 2022
3 tasks
osanseviero
approved these changes
Apr 21, 2022
…rectory * By default learner.export saves learner to learner.path * Before we where saving the model in learner.path and them moving it to save_directory * Fix by changing learner.path to being equal to save_directory
* Additionally, makes optional that the pyproject.toml contains the fastai and fastcore versions * Will continue to throw an error if the toml library is not available * Will continue to thrown an error if the pyproject.toml specifies fastai or fastcore versions that are not supported by from_pretrained_fastai * This will allow to load fastai models from the Hub that were not necessarily uploaded using push_to_hub_fastai.
…and "requires" section
* This allows to eliminate the returns when checking for the versions of fastai and fastcore in the pyproject.toml
* This allows to eliminate the returns when checking for the versions of fastai and fastcore in the pyproject.toml
…gingface_hub into add-fastai-mixin
…into add-fastai-mixin
osanseviero
approved these changes
Apr 26, 2022
|
Congrats @omarespejel! 🚀 🚀 🚀 |
|
Thank you @osanseviero @adrinjalali @muellerzr @nateraw! For your reviews and feedback 🤗🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I created a new PR (previous one: PR huggingface/huggingface_hub#416) I had a couple of mistakes with git, and seemed easier to create a new one. Thanks @muellerzr and @osanseviero for your comments!
What
fastai>=2.4(link) andfastcore>=1.3.27(link).Why
Learnersinvolves several changes and the fastai1 library has not been updated for over a year.2.0.6>= fastai <2.4involve complex changes.Fastaiwas updated due to what appear to be modifications to pytorch/serialization.py. For the sake of agility in our first release, I suggest releasing this version without supporting these previous versions.fastai>=2.4versions work withfastcore>=1.3.27version which is installed automatically whenfastai>=2.4is installed.How?
file_download.pychecks for fastcore and fastai availability and versions.config.jsonwhen pushed to hub.README.mdis automatically generated, if none, with thefastaitag.Testing?
fastai>=2.4versions work with the present code and with thefastcore==1.3.27version.Next?
fastai <2.4versions. I will ask on the fastai forums to assess how many users would require this support.