Skip to content

Commit

Permalink
Update contribution guide for merging PRs (#856)
Browse files Browse the repository at this point in the history
* Update CONTRIBUTING.md

* apply adrin review

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
  • Loading branch information
stevhliu and adrinjalali committed Apr 28, 2022
1 parent dabcc83 commit 627fdb2
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions CONTRIBUTING.md
Expand Up @@ -215,15 +215,17 @@ Follow these steps to start contributing:
$ git push -u origin a-descriptive-name-for-my-changes
```

7. Once you are satisfied (**and the checklist below is happy too**), go to the
6. Once you are satisfied (**and the checklist below is happy too**), go to the
webpage of your fork on GitHub. Click on 'Pull request' to send your changes
to the project maintainers for review.

8. It's ok if maintainers ask you for changes. It happens to core contributors
7. It's ok if maintainers ask you for changes. It happens to core contributors
too! So everyone can see the changes in the Pull request, work in your local
branch and push the changes to your fork. They will automatically appear in
the pull request.


8. Once your changes have been approved, one of the project maintainers will
merge your pull request for you.

### Checklist

Expand Down

0 comments on commit 627fdb2

Please sign in to comment.