Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Do not merge yet) Add CleanRL to Hub Documentation #447

Closed
wants to merge 5 commits into from

Conversation

simoninithomas
Copy link
Member

@simoninithomas simoninithomas commented Oct 23, 2022

⚠️ Do not merge for now (I opened a PR to visualize the result with doc builder) ⚠️

Costa worked on a new CleanRL integration for the Hub: vwxyzjn/cleanrl#292

In order to help CleanRL team to integrate it, I worked on the documentation on the Hub and the moon-landing integration.

For now since we don't have the final version of the integration, upload and download your models parts of the doc are not defined yet.

TODO:
🔲 Add in Librairies.ts the method to load_from_hub
🔲 Add track in Elastic.ts
🔲 Update the library with load_from_hub and push_to_hub

TODO From CleanRL PR:
🔲 Add in model card generation metadata["library_name"] = "cleanrl"

@simoninithomas simoninithomas changed the title Add CleanRL to Hub Documentation (Do not merge yet) Add CleanRL to Hub Documentation Oct 24, 2022
@julien-c julien-c marked this pull request as draft October 24, 2022 07:47
@julien-c
Copy link
Member

You can use the PR "draft" mode if it's not ready to merge yet 🙂

@osanseviero
Copy link
Member

@simoninithomas this seems quite outdated. Would you like to update it and merge it or should we close? Note: the JavaScript part of the code now lives in https://github.com/huggingface/huggingface.js

@simoninithomas
Copy link
Member Author

We can close it. I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants