Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Single file] fix single file config loading when passing dicts. #7934

Closed
wants to merge 1 commit into from

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul requested review from DN6 and yiyixuxu May 13, 2024 13:48
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh thanks! :)
looks good to me but I'll wait for @DN6 to comment if there is any reason the dict was not supported here

I think if we decided to accept config as a dict we should also update the doc string
if for some reason, we decide to no longer acceptconfig as a dict we should deprecate it

@yiyixuxu
Copy link
Collaborator

also I thought we are moving all the single-file tests to the same place? are these tests intended to be kept there?

@sayakpaul
Copy link
Member Author

Yeah, I think so too.

https://github.com/huggingface/diffusers/tree/main/tests/single_file has all the tests but I think we need to remove them from tests/models/unets/ and elsewhere.

@DN6
Copy link
Collaborator

DN6 commented May 21, 2024

Actually this test and functionality should be removed. We don't support configuring models via dict in from_pretrained so from_single_file shouldn't support it either. config should be a model repo id or a path to a local model repo. I'll update the test.

@sayakpaul
Copy link
Member Author

Closing the PR then :)

@sayakpaul sayakpaul closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants