Issue 6598: load_dataset broken for data_files on s3 #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matstrand
force-pushed
the
issue-6598-load-dataset-broken-s3
branch
4 times, most recently
from
bf3c8c2
to
88cc5a3
Compare
matstrand
force-pushed
the
issue-6598-load-dataset-broken-s3
branch
from
c3c0c06
to
ded2cac
Compare
lhoestq
reviewed
Jun 4, 2024
Comment on lines
+571
to
+574
| if scheme in ("s3", "s3a") and storage_options is not None and "hf" in storage_options: | ||
| # Issue 6598: **storage_options is passed to botocore.session.Session() | ||
| # and must not contain keys that become invalid kwargs. | ||
| del storage_options["hf"] |
There was a problem hiding this comment.
it would be great to have a more general solution for any filesystem than hardcoding something for S3
maybe in _prepare_single_hop_path_and_storage_options() in file_utils.py ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes /issues/6598
I've added a new test case and a solution. Before applying the solution the test case was failing with the same error described in the linked issue. I encountered this issue while following the Hugging Face documentation, trying to perform GPT-2 fine-tuning using
run_clm.pyon SageMaker with a data file stored on S3.MRE: