Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow connection objects in from_sql + small doc improvement #5091

Merged
merged 7 commits into from Oct 9, 2022
Merged

Allow connection objects in from_sql + small doc improvement #5091

merged 7 commits into from Oct 9, 2022

Commits on Oct 7, 2022

  1. Allow connecton objects in from_sql

    @mariosasko
    mariosasko committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    034bf18 View commit details
    Browse the repository at this point in the history

  2. Improve docs

    @mariosasko
    mariosasko committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c7a1961 View commit details
    Browse the repository at this point in the history

  3. Test

    @mariosasko
    mariosasko committed Oct 7, 2022
    1 Configuration menu
    Copy the full SHA
    353bec3 View commit details
    Browse the repository at this point in the history

  4. Add comment to test

    @mariosasko
    mariosasko committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    9390b7b View commit details
    Browse the repository at this point in the history

  5. Unused param

    @mariosasko
    mariosasko committed Oct 7, 2022
    1 Configuration menu
    Copy the full SHA
    b4b95ce View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Update src/datasets/packaged_modules/sql/sql.py 

    Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
    @mariosasko @lhoestq
    mariosasko and lhoestq committed Oct 9, 2022
    1 Configuration menu
    Copy the full SHA
    7ff5f87 View commit details
    Browse the repository at this point in the history

  2. Update docs/source/loading.mdx 

    Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
    @mariosasko @lhoestq
    mariosasko and lhoestq committed Oct 9, 2022
    1 Configuration menu
    Copy the full SHA
    f1d639b View commit details
    Browse the repository at this point in the history