Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AudioFolder packaged loader #4530
Add AudioFolder packaged loader #4530
Changes from 53 commits
cc87b0e
0adcd56
e46eecb
7cc4ab9
a648530
5cbbad1
53e9ce3
60760ea
e4bb688
d0b2592
15ca3cf
420dd2b
68b7f5a
7c75e81
eecc449
a081364
93c6afa
f5d9841
91afd92
cce1ebf
3c6c56a
6840eab
ffa6d14
aa2f246
d27266c
24a65fd
f9ee90d
c905c1b
f0ddbef
6c7a1f9
9f9551c
96189c2
66d3877
ba9d059
1346488
a0b4093
86fbb99
d1e4a64
b9eace0
6a841df
eabece2
d250bfd
edd4803
aab4746
997a01b
56d35aa
42627ba
76c319f
dce047e
74474fd
91c130b
0c33f73
7a8e384
75ac1f4
3ab6136
0b60893
bc1fb3d
b4c8a2d
676e6f3
724782e
bfecab4
90dc043
292a8c5
3e32181
fe80766
f74922c
227ce04
034b88c
54c6cf2
7f6719b
748576b
615a839
02f8f57
fc41118
9ee04ed
accb8cd
adccfd8
6a79a5f
189e98b
89e298c
fbef2b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would put this section first, since this is the main use case anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to say that I'm still in favor of setting it to None by default for consistency with imagefolder ^^'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I don't have a strong opinion here anymore :D
if we set
drop_labels=None
by default as you suggested, it might be confusing in cases when users provide only audio files, without metadata (or with broken metadata?). this is probably quite unlikely, so I'm ok with your suggestion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariosasko what do you think about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to be consistent, so I agree with @lhoestq.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm ok with that but it makes explaining things in documentation a bit more complicated...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've updated the docs, tried to make it simpler. still not sure that this logic with default None value of "drop_labels" is clear but I guess we'd better see what users say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhoestq @mariosasko what do you think about it now? 🤗
also, don't you know what's happening with the CI? why it takes forever and finally some jobs are cancelled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me ! :D
Not sure what's happening with the CI though. I just re-launched one job to see if it was caused by a bug in github actions or the windows runners