Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support #4460

Merged
merged 24 commits into from Jul 26, 2022
Merged

Drop Python 3.6 support #4460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3248518
Remove python 3.6 code
mariosasko Jun 8, 2022
6ad94e1
Update requirements
mariosasko Jun 8, 2022
3800c49
Style
mariosasko Jun 8, 2022
32aab3d
Update audio gh action
mariosasko Jun 8, 2022
2dee899
Benchmarks fix attempt #1
mariosasko Jun 8, 2022
8c6ce19
Benchmarks fix attempt no.2
mariosasko Jun 8, 2022
89b9ea6
Use newer image
mariosasko Jun 13, 2022
f9b24c4
Remove backticks
mariosasko Jun 13, 2022
8a82d72
Add suggested command to benchmark action
mariosasko Jun 13, 2022
3dbe753
Merge branch 'master' of github.com:huggingface/datasets into drop-py…
mariosasko Jun 13, 2022
6eab0e4
Avoid some FutureWarnings and DeprecationWarnings
mariosasko Jun 14, 2022
97ee698
Disable test
mariosasko Jun 16, 2022
1cdcaa5
Merge conflicts
mariosasko Jul 20, 2022
30de7fa
Remove 3.6 pickling test
mariosasko Jul 20, 2022
983b04e
CI test
mariosasko Jul 22, 2022
eac1aaa
Use python 3.7 in ubuntu-latest
mariosasko Jul 22, 2022
4db3cf9
Disable s3 test on Linux
mariosasko Jul 22, 2022
c4b4cb6
Merge branch 'main' of github.com:huggingface/datasets into drop-pyth…
mariosasko Jul 22, 2022
2674f0c
Remove weird json file
mariosasko Jul 26, 2022
c3bc52d
Remove cloudpickle stuff
mariosasko Jul 26, 2022
ad949dd
Use lower torchaudio version
mariosasko Jul 26, 2022
feebd90
Try to fix s3 errors
mariosasko Jul 26, 2022
59a1e3d
Another attempt
mariosasko Jul 26, 2022
9c2b16c
Disable test
mariosasko Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_arrow_dataset.py
View file
Open in desktop
Expand Up @@ -3119,7 +3119,7 @@ def test_pickle_dataset_after_transforming_the_table(in_memory, method_and_param


@pytest.mark.skipif(
os.name == "nt" and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"),
os.name in ["nt", "posix"] and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this ? The test currently passes on main on linux

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't on Python 3.7. Notice the test_dummy_dataset_serialize_s3 failure in one of the previous test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. This test is almost never run then, Maybe let's remove it completely in another PR, and make another one to make sure S3 export works as expected. Maybe we can use the mockfs fixture defined in #4724 instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue seems related to getmoto/moto#4750, but neither bumping moto to 3.0.0 (CI runs forever) nor pinning responses to 0.16 (the serialization fails) helps, so I agree we can disable these tests for now and replace them in another PR with the mockfs fixture

reason='On Windows CircleCI or GitHub Actions, it raises botocore.exceptions.EndpointConnectionError: Could not connect to the endpoint URL: "http://127.0.0.1:5555/test"',
) # TODO: find what's wrong with CircleCI / GitHub Actions
@require_s3
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dataset_dict.py
View file
Open in desktop
Expand Up @@ -665,7 +665,7 @@ def test_datasetdict_from_text_split(split, text_path, tmp_path):


@pytest.mark.skipif(
os.name == "nt" and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"),
os.name in ["nt", "posix"] and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"),
reason='On Windows CircleCI or GitHub Actions, it raises botocore.exceptions.EndpointConnectionError: Could not connect to the endpoint URL: "http://127.0.0.1:5555/test"',
) # TODO: find what's wrong with CircleCI / GitHub Actions
@require_s3
Expand Down