Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 support #4460
Drop Python 3.6 support #4460
Changes from 18 commits
3248518
6ad94e1
3800c49
32aab3d
2dee899
8c6ce19
89b9ea6
f9b24c4
8a82d72
3dbe753
6eab0e4
97ee698
1cdcaa5
30de7fa
983b04e
eac1aaa
4db3cf9
c4b4cb6
2674f0c
c3bc52d
ad949dd
feebd90
59a1e3d
9c2b16c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this ? The test currently passes on
main
on linuxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't on Python 3.7. Notice the
test_dummy_dataset_serialize_s3
failure in one of the previous testThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This test is almost never run then, Maybe let's remove it completely in another PR, and make another one to make sure S3 export works as expected. Maybe we can use the
mockfs
fixture defined in #4724 insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue seems related to getmoto/moto#4750, but neither bumping
moto
to3.0.0
(CI runs forever) nor pinning responses to0.16
(the serialization fails) helps, so I agree we can disable these tests for now and replace them in another PR with themockfs
fixture