New Textarea component #2476
Draft
New Textarea component #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
requested review from
ericmarcos,
asastre,
vanbasten17,
AinaVendrell and
AlbertGom
Iru89
force-pushed
the
refactor/extract-botonic-react-textarea
branch
from
3320cd0
to
03736ad
Compare
Unit Test Results1 files 1 suites 3s ⏱️ Results for commit 03736ad. |
Iru89
force-pushed
the
refactor/extract-botonic-react-textarea
branch
from
03736ad
to
024eb00
Compare
vanbasten17
force-pushed
the
refactor/extract-botonic-react-textarea
branch
from
fa7e54d
to
5b235a4
Compare
|
@Iru89 is this still in draft? |
yes |
…yled-components and @babel/preset-typescript
Iru89
force-pushed
the
refactor/extract-botonic-react-textarea
branch
from
5b235a4
to
31de8d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
When moving to node 16, npm 8 with react 17, we have problems with the react-textarea-autosize library.
The latest version fails the tests because it uses a forwardRef that doesn't work with jest, and the previous versions don't use react 17 so I have problems with peer dependencies.
With this we can reduce the final bundle by using less libraries.
Approach taken / Explain the design
I have created a textarea component with react styled-components and a hook to control the state. This way in the future from webchat we could make a custom component for the textarea and use the same hook to control the state.
It would be necessary to move all the attributes that are used inside the hook use-text-area to a context, so it would not be necessary to pass anything when calling this hook. I will make a refactor to achieve this.
By extracting the functions into a hook we also reduce the size of the webchat file which is too big.
To document / Usage example
Testing
The pull request...