WIP

hubtype · Mar 4, 2024 · 8fb3780 · 8fb3780
1 parent 3e4acc6
commit 8fb3780
Show file tree

Hide file tree

Showing 29 changed files with 9,539 additions and 12,185 deletions.
diff --git a/.github/workflows/botonic-ci-test-all-packages.yml b/.github/workflows/botonic-ci-test-all-packages.yml
@@ -1,4 +1,4 @@
-name: Botonic test all packages
+name: Botonic CI test all packages
 
 on:
   workflow_dispatch:
@@ -49,6 +49,7 @@ jobs:
       PACKAGE_NAME: Botonic plugin-dialogflow tests
       PACKAGE: botonic-plugin-dialogflow
       UNIT_TEST_COMMAND: npm run test_ci
+      BUILD_COMMAND: 'npm run build && cd ../botonic-core && npm run build'
       PUBLISH_TESTS_RESULTS: 'yes'
       NEEDS_CODECOV_UPLOAD: 'yes'
 
@@ -68,7 +69,7 @@ jobs:
     with:
       PACKAGE_NAME: Botonic plugin-google-analytics tests
       PACKAGE: botonic-plugin-google-analytics
-      BUILD_COMMAND: ''
+      BUILD_COMMAND: 'npm run build && cd ../botonic-core && npm run build'
       UNIT_TEST_COMMAND: ''
 
   botonic-plugin-inbenta-tests:
@@ -113,4 +114,5 @@ jobs:
     with:
       PACKAGE_NAME: Botonic react tests
       PACKAGE: botonic-react
+      BUILD_COMMAND: 'npm run build && cd ../botonic-core && npm run build'
       NEEDS_CODECOV_UPLOAD: 'yes'
diff --git a/.github/workflows/botonic-common-workflow.yml b/.github/workflows/botonic-common-workflow.yml
@@ -42,22 +42,26 @@ on:
         type: string
         description: 'Flag to know if the tests need some contentful secrets'
         required: false
+      NEEDS_BOTONIC_CORE:
+        type: string
+        description: 'Flag to know if the package needs to build @botonic/core'
+        required: false
 
 jobs:
-  bot-tests:
+  botonic-tests:
     name: ${{ inputs.PACKAGE_NAME }} tests
     runs-on: ubuntu-latest
     steps:
       - name: Checking out to current branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setting up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ inputs.NODE_VERSION }}
 
       - name: Setting up cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: ~/.npm
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
@@ -75,13 +79,17 @@ jobs:
           role-duration-seconds: 900
           role-session-name: HubtypeCITests
 
-      - name: Install dev dependencies
-        run: (cd ./packages/${{ inputs.PACKAGE }} && npm install -D)
+      - name: Install dependencies
+        run: npm install
 
       - name: Build
-        if: ${{ inputs.BUILD_COMMAND != '' }}
+        if: ${{ inputs.BUILD_COMMAND != '' }} && ${{ inputs.NEEDS_BOTONIC_CORE == '' }}
         run: (cd ./packages/${{ inputs.PACKAGE }} && ${{ inputs.BUILD_COMMAND }})
 
+      # - name: Build with botonic core
+      #   if: ${{ inputs.NEEDS_BOTONIC_CORE != '' && always() }}
+      #   run: (cd ./packages/botonic-core && ${{ inputs.BUILD_COMMAND }} && cd ../${{ inputs.PACKAGE }} && ${{ inputs.BUILD_COMMAND }})
+
       - name: Run tests
         if: ${{ inputs.UNIT_TEST_COMMAND != '' && always() && inputs.NEEDS_CONTENTFUL_SECRETS == '' }}
         run: (cd ./packages/${{ inputs.PACKAGE }} && ${{ inputs.UNIT_TEST_COMMAND }})
@@ -95,7 +103,7 @@ jobs:
           CONTENTFUL_TEST_MANAGE_TOKEN: ${{ secrets.CONTENTFUL_TEST_MANAGE_TOKEN }}
 
       - name: Verify lint
-        run: (cd ./packages/${{ inputs.PACKAGE }} && npm run lint_ci)
+        run: (cd ./packages/${{ inputs.PACKAGE }} && npm run lint_core)
 
       - name: Publish Unit Test Results
         if: ${{ inputs.PUBLISH_TESTS_RESULTS != '' && always() }}

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -27,12 +27,6 @@ repos:
         language: system
         files: ^packages/botonic-core/
 
-      - id: core-d-ts
-        name: core-d-ts
-        entry: scripts/qa/old/lint-d-ts.sh packages/botonic-core
-        language: system
-        files: ^packages/botonic-core/src/.*\.d\.ts
-
       - id: contentful
         name: contentful
         entry: scripts/qa/old/lint-package.sh packages/botonic-plugin-contentful
@@ -81,12 +75,6 @@ repos:
         language: system
         files: ^packages/botonic-react/
 
-      - id: react-d-ts
-        name: react-d-ts
-        entry: scripts/qa/old/lint-d-ts.sh packages/botonic-react
-        language: system
-        files: ^packages/botonic-react/src/.*\.d\.ts
-
       - id: google-analytics
         name: google-analytics
         entry: scripts/qa/old/lint-package.sh packages/botonic-plugin-google-analytics
@@ -105,12 +93,6 @@ repos:
         language: system
         files: ^docs/
 
-      - id: plugin-intent-classification
-        name: plugin-intent-classification
-        entry: scripts/qa/old/lint-package.sh packages/botonic-plugin-intent-classification
-        language: system
-        files: ^packages/botonic-plugin-intent-classification/
-
       - id: plugin-flow-builder
         name: plugin-flow-builder
         entry: scripts/qa/old/lint-package.sh packages/botonic-plugin-flow-builder