New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHOrganization.listSecurityManagers() #1832
base: main
Are you sure you want to change the base?
Conversation
Add support to list Security Managers in a GitHub Organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for CI.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
============================================
- Coverage 80.64% 80.55% -0.10%
+ Complexity 2358 2354 -4
============================================
Files 225 224 -1
Lines 7203 7193 -10
Branches 395 395
============================================
- Hits 5809 5794 -15
- Misses 1149 1153 +4
- Partials 245 246 +1 ☔ View full report in Codecov by Sentry. |
@bitwiseman : I would love to, but you need to add me to the test org so I can add a security maanger to run the tests against. Or is a unit test good enough for you? From the description of this PR:
|
@bitwiseman : I've added test response files that I've manually created and created unit tests based on those. Let me know if you want me to have real files from your test org, then you need to add me with permission to add a security team to the test org (or you can do it, and give me read access). |
Description
Add support to list Security Managers in a GitHub Organization. See GitHub's API doc for this API for more details about this API.
Tests:
If I'm given access to the
hub4j-test-org
Org, including permission to create a team and configure that team as a Security Manager team (or someone else can set this up for me), I can include an integration test (I didn't find a step-by-step process in CONTRIBUTING.md to get this access.Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: