Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Previews #1827

Merged
merged 7 commits into from Mar 24, 2024
Merged

Remove Previews #1827

merged 7 commits into from Mar 24, 2024

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Mar 22, 2024

Description

v2.x

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.66%. Comparing base (455fd41) to head (d9483cb).
Report is 1 commits behind head on main-2.x.

Files Patch % Lines
...c/main/java/org/kohsuke/github/GHOrganization.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             main-2.x    #1827      +/-   ##
==============================================
+ Coverage       80.02%   80.66%   +0.64%     
+ Complexity       2204     2192      -12     
==============================================
  Files             217      216       -1     
  Lines            6838     6620     -218     
  Branches          379      370       -9     
==============================================
- Hits             5472     5340     -132     
+ Misses           1128     1043      -85     
+ Partials          238      237       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 7fdeafa into hub4j:main-2.x Mar 24, 2024
8 checks passed
@bitwiseman bitwiseman deleted the v2/no-previews branch March 24, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant