Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we return an empty list when no reviews #1809

Merged
merged 1 commit into from Mar 11, 2024

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Mar 9, 2024

I couldn't reproduce the problem described in #1768 but I thought we could add a test anyway as it doesn't cost us much.

I couldn't reproduce the problem described in hub4j#1768 but I thought we
could add a test anyway as it doesn't cost us much.
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (2ee0bcc) to head (9bd83fb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1809      +/-   ##
============================================
- Coverage     80.69%   80.66%   -0.03%     
- Complexity     2332     2342      +10     
============================================
  Files           220      220              
  Lines          7050     7082      +32     
  Branches        373      379       +6     
============================================
+ Hits           5689     5713      +24     
- Misses         1128     1132       +4     
- Partials        233      237       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 06c3a27 into hub4j:main Mar 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants