Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit of marketPlace plans #1629

Merged
merged 4 commits into from Mar 20, 2023

Conversation

blacelle
Copy link
Contributor

@blacelle blacelle commented Mar 19, 2023

Description

This fixes an issue reported in #1613, where marketPlace plans type are not properly described (e.g. per-unit instead of PER_UNIT). This is confirmed by Github documentation https://docs.github.com/en/rest/apps/marketplace?apiVersion=2022-11-28#list-plans

Fixes #1613

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@blacelle
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (600933b) 79.64% compared to head (cb089b9) 79.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1629   +/-   ##
=========================================
  Coverage     79.64%   79.64%           
  Complexity     2187     2187           
=========================================
  Files           208      208           
  Lines          6657     6657           
  Branches        364      364           
=========================================
  Hits           5302     5302           
  Misses         1141     1141           
  Partials        214      214           
Impacted Files Coverage Δ
...va/org/kohsuke/github/GHMarketplacePriceModel.java 87.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bitwiseman bitwiseman merged commit 3cb78af into hub4j:main Mar 20, 2023
@bitwiseman
Copy link
Member

I've manually verified that this change matches the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - GET /marketplace_listing/accounts/{account_id}
2 participants