Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes template_repository information fixes #1549 #1579

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

robinvandenbogaard
Copy link

@robinvandenbogaard robinvandenbogaard commented Dec 14, 2022

Description

Include template repository in detailed representations. Fixes #1549
https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-repository-teams

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.05 ⚠️

Comparison is base (8b80485) 79.97% compared to head (00e157c) 79.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1579      +/-   ##
============================================
- Coverage     79.97%   79.93%   -0.05%     
- Complexity     2221     2222       +1     
============================================
  Files           213      213              
  Lines          6718     6723       +5     
  Branches        365      366       +1     
============================================
+ Hits           5373     5374       +1     
- Misses         1131     1133       +2     
- Partials        214      216       +2     
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHRepository.java 71.38% <20.00%> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI failures.

@robinvandenbogaard
Copy link
Author

Added the missing javadoc. I was using the wrong jdk for the mvn -D enable-ci clean install site to pass last month. It passes now locally.

@robinvandenbogaard
Copy link
Author

#1604 wrongfully closed this PR, it so happens to share the number 1579 with an identically numbered issue.

The fix in this PR still needs to be applied, please reopen.

@bitwiseman bitwiseman reopened this Jan 28, 2023
@bitwiseman
Copy link
Member

@robinvandenbogaard
Looks like we still need more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Get template repo details from created repository
2 participants