New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polymorphic deserialization for event account. #1522
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
=========================================
Coverage 79.89% 79.89%
Complexity 2197 2197
=========================================
Files 209 209
Lines 6670 6670
Branches 364 364
=========================================
Hits 5329 5329
Misses 1127 1127
Partials 214 214
☔ View full report in Codecov by Sentry. |
@bitwiseman Can you review my changes? I know checks are breaking, but this is because I change a method signature. I don't see how this can be avoided. P.S. I used the StackOverflow link you referenced in the issue as a source to implement the changes. |
@bloslo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, nicely done!
Add bridge methods to fix API breaks. The bridge will need to be a custom conversion method. And you'll need to add a test that makes sure the scenario where someone calls the old GHUser
method when the instance is now aGHOrganization
still works the same as before. You don't have to improve the behavior, just make sure it isn't any more broken.
@bitwiseman is there a chance to get this merged in? |
@Haarolean |
Description
Add polymorphic deserialization for the
GHAppInstallation
account
field.Fixes #1497
Before submitting a PR:
mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: