GitHub Actions Secrets (Repo and Org) simple CRUD operations ( and Get Public Key for Repo and Org as dependency) #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
added
the
work-abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added simple CRUD operations to GH Secrets (both Repository wise and Organization):
Also created a utility class for managing public keys, removing duplication between GHOrganization and GHRepository functionality. Created the following method for it and change the latter:
This broke the following, because instead of returning the type
GHRepositoryPublicKey, it returnsGHPublicKey:There is at least one incompatibility: org.kohsuke.github.GHRepository.getPublicKey():METHOD_RETURN_TYPE_CHANGED,org.kohsuke.github.GHRepositoryPublicKey.GHRepositoryPublicKey():CONSTRUCTOR_LESS_ACCESSIBLE,org.kohsuke.github.GHRepositoryPublicKey:CLASS_NO_LONGER_PUBLIC,org.kohsuke.github.GHRepositoryPublicKey:METHOD_ABSTRACT_ADDED_IN_SUPERCLASS,org.kohsuke.github.GHRepositoryPublicKey:CLASS_LESS_ACCESSIBLEStill figuring out the wire mock creation. Only tested it with
-Dtest.github.useProxy.Any support and comments are extremely welcome. Thanks!