Add logs in GitHubClient response. fix #1594

hub4j · Jan 11, 2023 · 087b8cb · 087b8cb
1 parent 472adbb
commit 087b8cb
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/src/main/java/org/kohsuke/github/GitHubClient.java b/src/main/java/org/kohsuke/github/GitHubClient.java
@@ -430,6 +430,7 @@ public <T> GitHubResponse<T> sendRequest(GitHubRequest request, @CheckForNull Bo
                 logRequest(connectorRequest);
                 rateLimitChecker.checkRateLimit(this, request.rateLimitTarget());
                 connectorResponse = connector.send(connectorRequest);
+                logResponse(connectorResponse);
                 noteRateLimit(request.rateLimitTarget(), connectorResponse);
                 detectKnownErrors(connectorResponse, request, handler != null);
                 return createResponse(connectorResponse, handler);
@@ -520,8 +521,23 @@ private GitHubConnectorRequest prepareConnectorRequest(GitHubRequest request) th
 
     private void logRequest(@Nonnull final GitHubConnectorRequest request) {
         LOGGER.log(FINE,
-                () -> "GitHub API request [" + (getLogin() == null ? "anonymous" : getLogin()) + "]: "
-                        + request.method() + " " + request.url().toString());
+                () -> String.format("(%s) GitHub API request [%s]: %s",
+                        Integer.toHexString(request.hashCode()),
+                        (getLogin() == null ? "anonymous" : getLogin()),
+                        (request.method() + " " + request.url().toString())));
+    }
+
+    private void logResponse(@Nonnull final GitHubConnectorResponse response) {
+        LOGGER.log(FINE, () -> {
+            try {
+                return String.format("(%s) GitHub API response [%s]: %s",
+                        Integer.toHexString(response.request().hashCode()),
+                        (getLogin() == null ? "anonymous" : getLogin()),
+                        (response.statusCode() + " " + GitHubResponse.getBodyAsString(response)));
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+        });
     }
 
     @Nonnull