Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump terraform-plugin-sdk to v2.24.0 #2447

Merged
merged 3 commits into from Oct 20, 2022

Conversation

ShiChangkuo
Copy link
Collaborator

@ShiChangkuo ShiChangkuo commented Oct 19, 2022

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #2401

Starting with Terraform v1.3, the terraform import command populates an empty state file with the imported resource and any data sources. Previously, only the target resource was written to the state file. This causes acceptance test steps with ImportState to fail if the configuration contains any data sources.

Excludes data sources from both original state and imported state. this issue was fixed by terraform-plugin-sdk to v2.24.0
(hashicorp/terraform-plugin-sdk#1077)

the PR includes the following changes:

  1. bump terraform-plugin-sdk to v2.24.0;
  2. requires Go 1.18+;
  3. update tfproviderlint:
    Ignoring bflad/tfproviderlint until internal error: package "context" without types was imported bflad/tfproviderlint#255 is fixed
    using ShiChangkuo/tfproviderlint instead

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

$ terraform version
Terraform v1.3.2
on linux_amd64

$ make testacc TEST='./huaweicloud/services/acceptance/ims' TESTARGS='-run=TestAccImsImage_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ims -v -run=TestAccImsImage_basic -timeout 360m -parallel 4
=== RUN   TestAccImsImage_basic
=== PAUSE TestAccImsImage_basic
=== CONT  TestAccImsImage_basic
--- PASS: TestAccImsImage_basic (415.06s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ims       415.132s

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Ignoring bflad/tfproviderlint until bflad/tfproviderlint#255 is fixed...
using ShiChangkuo/tfproviderlint instead
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@niuzhenguo
Copy link
Member

/lgtm

@github-actions github-actions bot added the LGTM /lgtm label Oct 20, 2022
@ShiChangkuo ShiChangkuo merged commit 63b94d5 into huaweicloud:master Oct 20, 2022
@ShiChangkuo ShiChangkuo deleted the sdkv2 branch August 7, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform sdk v2.10.0 会导致测试报错
2 participants