Social agent name should map to mission. #2008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears like this change causes a problem with combining groups of social agents. The agent mission ids are marked like I can strip away the prefix "social-actor-" but then group id is still integrated. This is necessary because missions are combined between groups which may share the underlying actor name. |
|
Given this case, I have now resorted to searching for the vehicles of interest in |
|
There is some consideration still here that the actor names should still be exactly named and unique between groups considering the actors are being combined across groups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make
Scenario.missions[]contain the social agent name instead of the mangled id.