Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix RuboCop Style/DoubleNegation #1

Closed
wants to merge 1 commit into from

Conversation

htwroclau
Copy link
Owner

See lostisland#854 - this PR fixes Style/DoubleNegation

@htwroclau htwroclau force-pushed the rubocop-Style-DoubleNegation branch 2 times, most recently from 933e274 to 5c3e62f Compare March 3, 2019 15:48
@olleolleolle
Copy link

Thanks for making a PR!

As an update to you: The rule was disabled in our configuration - we accept !! in our code.

So, this PR can be closed, the rule has been dealt with.

Thanks again, for working on Faraday!

@htwroclau
Copy link
Owner Author

@olleolleolle
Thank you for your comments!

lostisland#922
I understand it. (^^)/

@htwroclau htwroclau closed this Mar 4, 2019
@htwroclau htwroclau deleted the rubocop-Style-DoubleNegation branch March 4, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants