Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle responses in the reverse order from the requests #766

Merged
merged 1 commit into from Oct 14, 2023
Merged

Handle responses in the reverse order from the requests #766

merged 1 commit into from Oct 14, 2023

Conversation

souk4711
Copy link
Contributor

@souk4711 souk4711 commented Oct 6, 2023 •
edited

Resolve #767

BREAKING CHANGE:

@souk4711 souk4711 changed the title Make HTTP::Feature work like rack middleware [W.I.P] Make HTTP::Feature work like rack middleware Oct 6, 2023
@souk4711 souk4711 mentioned this pull request Oct 6, 2023
Closed
@souk4711 souk4711 changed the title [W.I.P] Make HTTP::Feature work like rack middleware Make HTTP::Feature work like rack middleware Oct 6, 2023
@souk4711 souk4711 changed the title Make HTTP::Feature work like rack middleware Handle responses in the reverse order from the requests Oct 6, 2023
@tarcieri tarcieri requested a review from ixti October 9, 2023 12:30
tarcieri
tarcieri approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more correct to me although I worry about shipping such a breaking change in a point release

@ixti
Copy link
Member

ixti commented Oct 14, 2023

@tarcieri we have a bunch of breaking changes that we can ship as major release.

@ixti ixti self-assigned this Oct 14, 2023
@tarcieri
Copy link
Member

Yeah that sounds fine

@ixti ixti merged commit 1ba37c2 into httprb:main Oct 14, 2023
8 checks passed
@souk4711 souk4711 deleted the feature/make-http-feature-work-like-rack-middleware branch October 14, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

@ixti ixti Awaiting requested review from ixti

Assignees

@ixti ixti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make HTTP::Feature work like rack middleware
3 participants
@souk4711 @ixti @tarcieri