Downcase Content-Type charset name #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into an issue making requests to a server I don't control (Microsoft ASP.NET) where it was giving me errors POSTing JSON. This header works: `Content-Type: application/json; charset=utf-8` This did not: `Content-Type: application/json; charset=UTF-8` HTTP.rb uses Ruby `String#encoding.name`, which returns "UTF" in all caps, which is causing the `charset=UTF-8`. [MDN says "Case insensitive, lowercase preferred"](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type), so I just downcased the encoding name, and added a test.
paul
force-pushed
the
downcase-charset-encoding
branch
from
1941bdd
to
326ccb0
Compare
tarcieri
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue making requests to a server I don't control (Microsoft ASP.NET) where it was giving me errors POSTing JSON with
HTTP.post(path, json: {whatever}).This header works:
Content-Type: application/json; charset=utf-8This did not:
Content-Type: application/json; charset=UTF-8HTTP.rb uses Ruby
String#encoding.name, which returns "UTF" in all caps, which is causing thecharset=UTF-8.MDN says "Case insensitive, lowercase preferred", so I just downcased the encoding name, and added a test.