Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access the HTTP::Request from the HTTP::Response #546

Merged
merged 2 commits into from Oct 21, 2019
Merged

Access the HTTP::Request from the HTTP::Response #546

merged 2 commits into from Oct 21, 2019
+34 −12

Commits on Oct 20, 2019

  1. Access the HTTP::Request from the HTTP::Response 

    This fixes httprb#463

This will greatly enhance the abilities of pluggable `Features` by
being able to reference the Request that initiated a Response.
    @joshuaflanagan
    joshuaflanagan committed Oct 20, 2019
    Copy the full SHA
    36a7a40 View commit details
    Browse the repository at this point in the history

  2. Response#uri can be set directly, or pulled from the Request 

    During normal operation, the Response#uri will be pulled from
the Request passed into the Response. However, we still allow explicitly
setting a `:uri` option when creating a Response, for backwards compatibility.

This was motivated by rubocop/code climate complaining that `Client#perform`
was now 1-line too long. I'll defer to the project maintainers to decide
if that is a good thing.
    @joshuaflanagan
    joshuaflanagan committed Oct 20, 2019
    Copy the full SHA
    57ecccc View commit details
    Browse the repository at this point in the history