Validate headers (fix name validation and ensure there is no new line character in the header value) #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonias
changed the title
Bonias
force-pushed
the
validate-headers
branch
from
3b99add
to
0eaaef2
Compare
ixti
approved these changes
Feb 12, 2019
|
@Bonias please rebase on top of the master and I'll be happy to merge. |
added 2 commits
February 12, 2019 23:35
Match beginning and end of string instead beginning and end of linee
Bonias
force-pushed
the
validate-headers
branch
from
0eaaef2
to
90b1f8b
Compare
it's done |
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.