Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0 #659

Closed
tarcieri opened this issue Apr 30, 2021 · 5 comments
Closed

Release 5.0 #659

tarcieri opened this issue Apr 30, 2021 · 5 comments
Assignees

Comments

@tarcieri
Copy link
Member

Supersedes #564.

It'd probably be good to ship 5.0, even in the current state, for better or worse.

There will no doubt be bugs but it will at least move things forward.

@tarcieri tarcieri mentioned this issue Apr 30, 2021
@ixti ixti self-assigned this Apr 30, 2021
@tarcieri
Copy link
Member Author

Opened a PR for this: #660

@tarcieri
Copy link
Member Author

It's out! 🎉

https://rubygems.org/gems/http/versions/5.0.0

@jrnk
Copy link

jrnk commented May 18, 2021

@tarcieri first: thanks for shipping 5.0 👍
One issue I see in the 5.0 release that wasn't in rc3: it seems like although it is mentioned in the changelog:

#593 #592 Support informational (1XX) responses. (@ixti)

That commit is missing from the release, HTTP 100 responses worked with rc3, but stopped working with this 5.0 release.

@tarcieri
Copy link
Member Author

@jrnk not sure what the problem is. Can you open an issue?

@jrnk
Copy link

jrnk commented May 18, 2021

@tarcieri sure! The problem is that the mentioned changes that should be in the 5.0 release are not present :)
I will open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants