Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive _errno_from_exception #228

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Recursive _errno_from_exception #228

merged 5 commits into from
Oct 28, 2022

Conversation

gustafsson
Copy link
Contributor

Similar to #202 but the socket.error may also have empty args so check the length again, or revert to the errno field.

When I was using a proxy that dropped the connection I got this error message

socks.GeneralProxyError: Connection closed unexpectedly

During handling of the above exception, another exception occurred:
...
  File "~/Applications/google-cloud-sdk/platform/gsutil/third_party/httplib2/python3/httplib2/__init__.py", line 195, in _errno_from_exception
    return e_int.args[0].errno if isinstance(e_int.args[0], socket.error) else e_int.errno
IndexError: tuple index out of range

httplib2_IndexError_tuple_index_out_of_range.txt

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #228 (1141e7e) into master (a309035) will decrease coverage by 0%.
The diff coverage is 75%.

Additional details and impacted files
Impacted Files Coverage Δ
python3/httplib2/__init__.py 83% <75%> (-1%) ⬇️
python2/httplib2/__init__.py 83% <0%> (+<1%) ⬆️

@temoto temoto merged commit 12a76ea into httplib2:master Oct 28, 2022
@temoto
Copy link
Member

temoto commented Oct 28, 2022

thank you, recursive version is cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants