Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle PySocks ProxyConnectionError #202

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Handle PySocks ProxyConnectionError #202

merged 2 commits into from
Oct 11, 2021

Commits on Oct 11, 2021

  1. Handle PySocks ProxyConnectionError 

    In the presence of PySocks, httplib2 falls back on it instead of its own bundled `socks.py`. However, exception `ProxyConnectionError` produced by PySocks is a bit different that expected, it lacks `args`. An attempt to extract `errno` from it fails with `IndexError: tuple index out of range` (see httplib2#170). The patch addresses this.
    @ivanyu @temoto
    ivanyu authored and temoto committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    fc50f9f View commit details
    Browse the repository at this point in the history

  2. !fixup doc

    @temoto
    temoto committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7acd622 View commit details
    Browse the repository at this point in the history