Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pytest warning about deprecated use --strict in setup.cfg #194

Closed
wants to merge 1 commit into from
Closed

Conversation

kloczek
Copy link

@kloczek kloczek commented May 13, 2021

Fixes pytest warning reported in #192

../../../../../usr/lib/python3.8/site-packages/_pytest/config/init.py:1183
/usr/lib/python3.8/site-packages/_pytest/config/init.py:1183: PytestDeprecationWarning: The --strict option is deprecated, use --strict-markers instead.
self.issue_config_time_warning(

Based on pytest-dev/pytest#8668

Signed-off-by: Tomasz Kłoczko kloczek@github.com

Fixes pytest warning reported in #192

../../../../../usr/lib/python3.8/site-packages/_pytest/config/__init__.py:1183
  /usr/lib/python3.8/site-packages/_pytest/config/__init__.py:1183: PytestDeprecationWarning: The --strict option is deprecated, use --strict-markers instead.
    self.issue_config_time_warning(

Based on pytest-dev/pytest#8668

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@temoto
Copy link
Member

temoto commented May 14, 2021

@kloczek it fails because requirements-test.txt specifies pytest==3.2.1 which doesn't support strict-markers yet.

@kloczek
Copy link
Author

kloczek commented May 14, 2021

pytest==3.2.1 is really ancient version :/
Latest one which I'm usinng is 6.2.4.

@temoto
Copy link
Member

temoto commented May 14, 2021

Having that ancient version in separate environment will not hurt the other pytest you are using.

As of today (2021-05) httplib2 is not tested by external any pytest. It is tested using script/test in repo. script/test creates by default, or uses existing python environment and installs requirements-test.txt into it. This way there is a guarantee that what was tested on CI server will also be run tested exactly same way on any developer machine.

I'm fine with upgrading pytest in requirements-test.txt if there is a good reason.

For any patch to be merged, it must pass CI tests.

@temoto
Copy link
Member

temoto commented Nov 18, 2021

Thanks, this fix is merged in master.

@temoto temoto closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants