proxy: urllib getproxies works with OS specific sources (like Windows registry) #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Public test is much appreciated.
|
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 76.16% 76.14% -0.02%
==========================================
Files 8 8
Lines 2618 2616 -2
==========================================
- Hits 1994 1992 -2
Misses 624 624
Continue to review full report at Codecov.
|
temoto
force-pushed
the
urllib-proxy
branch
from
249bad0
to
9835dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natan Rajchenberg approached me via email with this patch. Using urllib
getproxieshandles OS specific sources other than environment variables.LGTM, but have to check for compatibility.