Relative import iri2uri #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 75.68% 75.68%
=======================================
Files 8 8
Lines 2616 2616
=======================================
Hits 1980 1980
Misses 636 636
Continue to review full report at Codecov.
|
Update: sorry, of course python3 already has it written as relative import. |
|
I'm sorry. The SG-16899 reference and #1 were used for the commit on our own fork. Submitting a PR from that master branch carried the same info. |
|
Please remove that if you want your commit merged intact. Otherwise I'd change commit message. |
Fixes an ImportError when using IronPython 2.7
|
Done |
|
Thank you very much. |
|
Released in 0.17.3 |
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IronPython 2.7, importing httplib2 can raise an ImportError. It seems like a bug in IronPython but switching iri2uri's import to a relative import solves the issue and will still work in other python implementations.
I've put together a simplified example of the structure that can cause the import error in IronPython in code_structure.zip. It seems that under certain circumstances, once a relative import has been executed, the following absolute import does not search the local directory.