Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug in HTTPSConnectionWithTimeout.connect #162

Merged
merged 1 commit into from Apr 10, 2020
Merged

Fix debug in HTTPSConnectionWithTimeout.connect #162

merged 1 commit into from Apr 10, 2020

Conversation

cjwatson
Copy link
Contributor

There was one more layer of parentheses than there should have been.

Fixes #161.

There was one more layer of parentheses than there should have been.

Fixes #161.
@temoto
Copy link
Member

temoto commented Apr 10, 2020

Thank you very much.

Just a side note: you don't have to create both issue and pull request. Either one is enough.

@cjwatson
Copy link
Contributor Author

Sorry for the noise; in this case it was because I wanted to put a real-world reproduction recipe somewhere, but didn't feel it quite belonged in a PR. But noted for the future.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #162 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   75.68%   75.68%           
=======================================
  Files           8        8           
  Lines        2616     2616           
=======================================
  Hits         1980     1980           
  Misses        636      636           
Impacted Files Coverage Δ
python3/httplib2/__init__.py 83.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d490f6...59586b5. Read the comment docs.

@temoto temoto merged commit 59586b5 into httplib2:master Apr 10, 2020
@github-pages github-pages bot temporarily deployed to github-pages April 10, 2020 23:10 Inactive
@cjwatson cjwatson deleted the py3-fix-https-connect-debug branch April 10, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPSConnectionWithTimeout.connect crashes on Python 3 with debuglevel > 0
2 participants