Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for proxy bypass in HTTPConnectionWithTimeout #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamescasbon
Copy link

This allows the connection to pick up no_proxy from the environment.

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files           8        8           
  Lines        2547     2547           
=======================================
  Hits         1874     1874           
  Misses        673      673
Impacted Files Coverage Δ
python3/httplib2/__init__.py 83.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26ed02...3e5b2b9. Read the comment docs.

@temoto
Copy link
Member

temoto commented Jan 10, 2019

Thank you. Looks useful. Likely need same addition in all 4 combinations of python{2,3} {http,https}connection. And test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants