Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed ubuntu installation step 2 #1534

Closed
wants to merge 1 commit into from
Closed

Conversation

ginruh
Copy link

@ginruh ginruh commented Oct 12, 2023

Addresses #1533

@ginruh
Copy link
Author

ginruh commented Oct 12, 2023

It's the same command but now can run without permission errors.

@@ -39,7 +39,7 @@ tools:
install:
- curl -SsL https://packages.httpie.io/deb/KEY.gpg | sudo gpg --dearmor -o /usr/share/keyrings/httpie.gpg
# - curl -SsL -o /etc/apt/sources.list.d/httpie.list https://packages.httpie.io/deb/httpie.list
- sudo echo "deb [arch=amd64 signed-by=/usr/share/keyrings/httpie.gpg] https://packages.httpie.io/deb ./" > /etc/apt/sources.list.d/httpie.list
- sudo sh -c 'echo "deb [arch=amd64 signed-by=/usr/share/keyrings/httpie.gpg] https://packages.httpie.io/deb ./" > /etc/apt/sources.list.d/httpie.list'
Copy link

@horw horw Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is also another way to do it.

echo "deb [arch=amd64 signed-by=/usr/share/keyrings/httpie.gpg] https://packages.httpie.io/deb ./" | sudo tee -a /etc/apt/sources.list.d/httpie.list

Copy link
Author

@ginruh ginruh Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use your command instead and update PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just my comment here. These commands are almost equal.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recommend both of them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tee variant is most common. Note that it Should not be -a to be equivalent with the original meaning.

@mloskot
Copy link

mloskot commented Nov 24, 2023

This PR seems solid and ready, can this be merged?

@jkbrzt
Copy link
Member

jkbrzt commented Mar 4, 2024

Thanks, @ginruh! Fixed via #1557.

@jkbrzt jkbrzt closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants