Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying of status code without a status message. #1301

Merged
merged 2 commits into from Mar 3, 2022

Conversation

isidentical
Copy link
Contributor

Fixes #1300

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #1301 (6f25c8e) into master (4d7d6b6) will decrease coverage by 0.61%.
The diff coverage is 95.40%.

❗ Current head 6f25c8e differs from pull request most recent head 895535c. Consider uploading reports for the commit 895535c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   97.28%   96.66%   -0.62%     
==========================================
  Files          67       85      +18     
  Lines        4235     6031    +1796     
==========================================
+ Hits         4120     5830    +1710     
- Misses        115      201      +86     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <58.33%> (-9.82%) ⬇️
tests/test_ssl.py 91.01% <66.66%> (-3.93%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/output/lexers/http.py 86.36% <86.36%> (ø)
httpie/models.py 94.23% <90.00%> (-3.14%) ⬇️
tests/test_uploads.py 97.70% <92.59%> (-2.30%) ⬇️
httpie/manager/core.py 92.85% <92.85%> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f77e14...895535c. Read the comment docs.

@jkbrzt
Copy link
Member

jkbrzt commented Feb 23, 2022

@isidentical not sure if you’ve noticed the subtle detail that there can be a space after the code in the phrase-less version. So all these are possible:

HTTP/1.1 200 OK
HTTP/1.1 200
HTTP/1.1 200<space>

It would be good to have explicit tests for the last variant as well.

@jkbrzt jkbrzt merged commit 25bd817 into httpie:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to See Status Code in Output
3 participants