New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper JSON handling for :=/:=@ #1213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
- Coverage 97.28% 96.75% -0.54%
==========================================
Files 67 72 +5
Lines 4235 4677 +442
==========================================
+ Hits 4120 4525 +405
- Misses 115 152 +37
Continue to review full report at Codecov.
|
@jakubroztocil do you have any idea about why the links from the coverage bot is not working? I can't see what part decreased the cover, since every link I click is broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻 Tweaked the docs a bit. Please also add a CHANGELOG entry.
docs/README.md
Outdated
Be aware that when using this syntax with form data (`--form` is activated); | ||
only strings, numbers and floats are enabled. Rest of the JSON types are not | ||
available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that when using this syntax with form data (`--form` is activated); | |
only strings, numbers and floats are enabled. Rest of the JSON types are not | |
available. | |
The `:=` syntax is JSON-specific. You can switch your request to `--form` or `--multipart`, | |
and string, float, and number values will continue to be serialized (as string form values). | |
Other JSON types, however, are not allowed with `--form` or `--multipart`. | |
edc6c4b
to
ed39240
Compare
Fixes #1212